-
Notifications
You must be signed in to change notification settings - Fork 33
Chronicle agent server address resolution fixes #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…discovery is disabled Require server address be specified if auto-discovery is disabled
Fail template if no server address is resolved
bc17041
to
73219d1
Compare
matt-urbina
reviewed
Oct 9, 2025
Comment on lines
-5
to
+6
version: 0.1.34 | ||
appVersion: 0.1.34 | ||
version: 0.1.35 | ||
appVersion: 0.1.35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this merges we will create a secondary PR for Connect and Workbench to use this version
jforest
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤘
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rstudio-library
whenchronicleAgent.autoDiscovery=false
. RequirechronicleAgent.serverAddress
be specified instead.rstudio-library.chronicle-agent.serverAddress
to check if the lookup returns an empty value.rstudio-library.chronicle-agent.serverAddress
render if no server address can be resolved.